-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make feedback button localizable #9215
Comments
The German localization is incomplete. If you can, please consider contributing to the localization. Thank you! |
@1ec5 I requested access to join the team. Could u please approve? |
Welcome to the translator team, @evgzor! |
@1ec5 Many thanks for the approvement of invitation. We will translate all German strings. However, I did not find for translation string "Improve This Map". Could u please explain how possible to add it or where is it? |
Ah, I didn’t realize you were referring to that particular item. The attribution items, including the “Improve This Map” button, come from the TileJSON files used by the sources in the current style. (For example, the default Mapbox Streets v9 style uses the Mapbox Streets v7 source, which defines the top three attribution items.) mapbox/tilejson-spec#20 tracks allowing TileJSON sources to provide localized attribution items. Given that we’re already overriding the feedback link’s URL as of #9078, it isn’t unrealistic to override the “Improve This Map” string and make it localizable like it used to be (before #5999 landed). In fact, that would enable us to remove the fancy capitalization code added in #7651. |
@1ec5 Could u please let me know when it would be localized for "Improve This Map" – "Verbessere diese Karte" in German ? |
This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
iOS 10.3
3.5.4
Steps to trigger behavior
Expected behavior
All items is localized or at least allow to be localize with any workarounds
Actual behavior
Some of the menu items are not localized:
The text was updated successfully, but these errors were encountered: