Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Style.java #9338

Closed
tobrun opened this issue Jun 22, 2017 · 4 comments
Closed

Style.java #9338

tobrun opened this issue Jun 22, 2017 · 4 comments
Assignees
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules

Comments

@tobrun
Copy link
Member

tobrun commented Jun 22, 2017

With #9280, style has been promoted to be part of the public api that core exposes for bindings. This change could be propagated to the Android binding by exposing Style.java to match the API and functionality more closely. Adding a semver label, though we could ship intermediate versions with deprecation notices.

cc @mapbox/android

@tobrun tobrun added Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Jun 22, 2017
@lilykaiser lilykaiser added this to the android-v6.0.0 milestone Oct 2, 2017
@tobrun
Copy link
Member Author

tobrun commented Jan 18, 2018

I'm proposing the match the API exposed by style.hpp. Concretely this will mean moving methods from MapboxMap.java to Style.java. With this move, I'm also suggesting to implement the native methods directly on Style.java instead of facading through NativeMapView.java.

@tobrun
Copy link
Member Author

tobrun commented Jan 18, 2018

Additional API changes will need to occur around the OnMapReady and the OnStyleLoadedListener callback. These will be given an additional Style parameter:

public interface OnMapReadyCallback {
  void onMapReady(MapboxMap mapboxMap, Style style);
}

@LukasPaczos
Copy link
Contributor

Great idea @tobrun. With this change, we could restrict adding new style URL/path to the constructor or builder of the Style which would indicate that all the programmatically added components should be re-added, as we are creating a new Style object. This would easily resolve most of the issues from #10947.

@tobrun tobrun mentioned this issue Jan 19, 2018
10 tasks
@tobrun tobrun modified the milestones: android-v6.0.0, android-v7.0.0 Apr 13, 2018
@tobrun tobrun removed this from the android-v7.0.0 milestone Sep 19, 2018
@tobrun tobrun added this to the android-v7.0.0 milestone Oct 24, 2018
@tobrun tobrun self-assigned this Oct 24, 2018
@tobrun
Copy link
Member Author

tobrun commented Dec 10, 2018

done in #13484

@tobrun tobrun closed this as completed Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants