Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Return an error object removeSource: is called on an in use MGLSource #9692

Closed
jmkiley opened this issue Aug 3, 2017 · 2 comments
Closed

Return an error object removeSource: is called on an in use MGLSource #9692

jmkiley opened this issue Aug 3, 2017 · 2 comments
Assignees
@julianrex
Labels
feature iOS Mapbox Maps SDK for iOS needs discussion

Comments

@jmkiley
Copy link
Contributor

jmkiley commented Aug 3, 2017

Currently the SDK prints a console message when a MGLSource that is still being used by a MGLStyleLayer is removed. It may be more helpful to throw an error that can then be handled by developers.
@jmkiley jmkiley added feature iOS Mapbox Maps SDK for iOS labels Aug 3, 2017
@jfirebaugh
Copy link
Contributor

Previously: #9129.

@chloekraw chloekraw added the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label Oct 5, 2018
This was referenced Nov 15, 2018
Closed
Closed
@julianrex julianrex self-assigned this Nov 16, 2018
@julianrex julianrex mentioned this issue Nov 16, 2018
Merged
@julianrex
Copy link
Contributor

Closed in #13399 - by adding a new method. As such this was not a SEMVER-MAJOR change.

@julianrex julianrex removed the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@julianrex julianrex

Labels
feature iOS Mapbox Maps SDK for iOS needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jfirebaugh @julianrex @jmkiley @chloekraw