This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Deprecate style class API #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
added
iOS
boundsj
approved these changes
Jan 19, 2017
|
Looks 👍 to me. Added |
|
To clarify, this is about the style class API, not the style API (aka the runtime styling API). |
boundsj
removed
the
⚠️ DO NOT MERGE
|
@fabian-guerra I changed the milestone to be 3.5.0. I think you can go ahead and target this against the master branch and merge it. |
1ec5
approved these changes
Jan 25, 2017
fabian-guerra
force-pushed
the
fabian-deprecate-style-api-methods
branch
3 times, most recently
from
9af2844 to
140abfc
Compare
friedbunny
force-pushed
the
fabian-deprecate-style-api-methods
branch
from
140abfc to
917f3a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #7577 and #2875 we should mark style methods and properties as deprecated because we will not support them on future releases.
The Android SDK has already deprecated same API.
This is a temporarily PR to branch release-ios-v3.4.0, this should be included in release-ios-v3.4.1