Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Rename line-dasharray to line-dash-array #647

Closed
1ec5 opened this issue Jan 5, 2017 · 3 comments
Closed

Rename line-dasharray to line-dash-array #647

1ec5 opened this issue Jan 5, 2017 · 3 comments
Labels
breaking change

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 5, 2017

The line-dasharray property should be renamed line-dash-array. The missing dash really bugs me, and if we were to go through with #638, lineDasharray would look sloppy.

/cc @lucaswoj @tmcw
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 5, 2017

Note that the iOS and macOS SDKs call this property lineDashPattern for consistency with the platform (and MapKit).

@mourner
Copy link
Member

mourner commented Jan 5, 2017

AFAIR the original reason there's no dash is that SVG spec doesn't have it too, e.g. https://developer.mozilla.org/ru/docs/Web/SVG/Attribute/stroke-dasharray, and we wanted it to be consistent with existing web specs.

@1ec5 1ec5 mentioned this issue Jan 5, 2017
Closed
6 tasks
@lucaswoj lucaswoj mentioned this issue Feb 1, 2017
Closed
@lucaswoj
Copy link

lucaswoj commented Feb 1, 2017

This issue was moved to mapbox/mapbox-gl-js#4167

@lucaswoj lucaswoj closed this as completed Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mourner @lucaswoj @1ec5