Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java 8 features from geojson module #868

Closed
tobrun opened this issue Aug 15, 2018 · 3 comments · Fixed by #876
Closed

Remove Java 8 features from geojson module #868

tobrun opened this issue Aug 15, 2018 · 3 comments · Fixed by #876

Comments

@tobrun
Copy link
Member

tobrun commented Aug 15, 2018

Request to remove java 8 from geojson module and as result remove the static method decleration of toJson on the Geometry interface, see here. Since the method isn't public can we patch this up without breaking semver?

cc @osana @zugaldia

@zugaldia
Copy link
Member

@osana could you run with this? Ideally this would be part of the upcoming f Maps SDK release.

@osana
Copy link
Contributor

osana commented Aug 15, 2018

@zugaldia @tobrun By making GeoJson and abstract class instead of an interface we do not need to remove any methods. Please see the PR if you are Ok with that

@tobrun
Copy link
Member Author

tobrun commented Aug 16, 2018

afaik the only thing to address is reverting https://github.com/mapbox/mapbox-java/blob/master/services-geojson/src/main/java/com/mapbox/geojson/Geometry.java#L26 as this is a java 8 specific feature (static methods on interfaces). Next to that we need to set the compile version back to 1.7. I'm not seeing the need for the changes made in #833, those should compile with java 7 without a change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants