Native crash after clicking re-center, backgrounding the app before re-center finishes and then re-opening. #1865
Labels
bug
Defect to be fixed.
Comments
|
I have similar issue since I have migrated my app from Mapbox Navigation SDK version: 0.33.0 to Mapbox Navigation SDK version: 0.34.0 with targetSdkVersion 28.
2019-04-05 12:50:02.492 4671-4732/io.company.myapplication A/libc: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x1c0 in tid 4732 (GLThread 10566) |
|
I was able to reproduce the following Maps native crash with the steps described 👀 After bisecting latest commits I found that the issue was introduced by #1844 - bumping Maps SDK version to In any case, that's different than the one you saw @DejanRistic, were you able to reproduce using Mapbox Navigation SDK v0.33.2? Could you add some more information for reproducing the issue (minimal example) or any other specifics around your test setup? If there is any sample or pseudo code you can provide, that would be really helpful, because without having additional information I'm unable to reproduce that |
|
Issue not seen with v0.33.2 |
|
Thanks for the update @saravanadinesh I wasn't able to reproduce with Wondering if @DejanRistic can reproduce the issue described in OP. I wasn't able to reproduce that one, not even with In the meantime, we're working on a fix for the upstream Thank you for your patience. |
|
@Guardiola31337 you're right, i confused the crash @saravanadinesh found with the one I saw in our application because the repro was similar. Testing the sample app before the mapbox version update i'm not able to repro my original crash there. I still get the OP crash in our app, but since I can't repro it in the sample app we can close this if there's a fix for the crash you were able to repro. I think my crash might be related to accessing layers after coming back into the app. We update the visibility of some of the mapbox views and replace them with our own. Maybe related to this: |
|
Awesome, thanks for confirming @DejanRistic
Yeah, most likely, there's an update pushed to the I'm going to leave this ticket opened until we figure / fix the other crash that we're seeing. We'll report back here. Thanks again! cc @LukasPaczos |
|
To look more into this we need know a bit more about what is going wrong, we need to be able to pinpoint where the crash originates. That can be done with either:
One additional thing that would be interesting is to verify if enabling TextureView makes any difference. |
This is testing
Going to test now if I can reproduce enabling |
|
@Guardiola31337 the stacktrace shows that queryRenderedFeatures is responsible. Considering this is the only occurrence I could find by quickly searching the codebase. I'm sure the issue is related to: Could you verify that above is responsible? Can you validate that this is being called when the underlying surface isn't ready? |
Looking now. Wondering though what has changed in the Maps side because we haven't seen this issue until
I wasn't able to reproduce the crash with |
|
Upstream fix 👉 mapbox/mapbox-gl-native#14395 |
|
I've just confirmed that mapbox/mapbox-gl-native#14395 fixed the crash 🎉 Thanks for the quick fix @mapbox/maps-android |
4 tasks
|
mapbox android sdk version 7.3.2 also gettig this error. any solution? |
|
@tests1028 are you using v7.3.2 directly, or via the Mapbox Navigation SDK? |
|
Yah directly I used 7.3.2 library project |
|
@tests1028 In that case, could you open a new ticket for Maps SDK on https://github.com/mapbox/mapbox-gl-native? This ticket tracks navigation-specific issues. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Android API: Android 9 (Target API 28)
Mapbox Navigation SDK version: 0.34.0
I first saw this with our own app, then tried it using the navigation sample from this repo.
Steps to trigger behavior
Expected behavior
Application doesn't crash.
Actual behavior
Application crashes.
I wasn't able to get a huge backtrace when using the sample app, but I do see this bit:
With our app i get a better trace:
The text was updated successfully, but these errors were encountered: