Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate route gradient stop property declaration in NavigationMapView #2423

Closed
captainbarbosa opened this issue Jun 24, 2020 · 0 comments · Fixed by #2580
Closed

Investigate route gradient stop property declaration in NavigationMapView #2423

captainbarbosa opened this issue Jun 24, 2020 · 0 comments · Fixed by #2580
Assignees
Labels
bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Milestone

Comments

@captainbarbosa
Copy link
Contributor

Following up on #2377 (comment),

NavigationMapView declares two gradient stop dictionaries in the form of a tuple, used to calculate the traffic line gradients for both the main route line and its casing:

typealias RouteGradientStops = (line: [CGFloat: UIColor], casing: [CGFloat: UIColor])
private var routeGradientStops = RouteGradientStops(line: [:], casing: [:])

It was suggested in #2377 (comment) that this be changed to two parallel properties instead, such as:

private var routeGradientStops: [CGFloat: UIColor] = [:]
private var routeGradientCasingStops: [CGFloat: UIColor] = [:]

However, this declaration causes the gradient stops to be miscalculated - we should look into why this is happening.

Screen Shot 2020-06-24 at 3 58 47 PM Screen Shot 2020-06-24 at 3 57 33 PM
Tuple Two parallel properties

* note - the line caps are not rounded in these two screenshots, but since those were taken that has been corrected.

cc @1ec5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants