Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move offline downloads off of the main thread #282

Closed
cammace opened this issue Feb 16, 2018 · 2 comments
Closed

Move offline downloads off of the main thread #282

cammace opened this issue Feb 16, 2018 · 2 comments
Labels
offline-plugin Issues that deal with the offline plugin module

Comments

@cammace
Copy link
Contributor

cammace commented Feb 16, 2018

We currently make use of a Android service to download a region but this is running on the main thread. It'd be more performant to move this over to a separate thread.
@cammace cammace added the offline-plugin Issues that deal with the offline plugin module label Feb 16, 2018
@cammace cammace added this to the offline-0.1.0 milestone Feb 16, 2018
@cammace cammace modified the milestones: offline-0.1.0, offline-0.2.0 Apr 18, 2018
@cammace
Copy link
Contributor Author

cammace commented Apr 18, 2018

Currently blocked by mapbox/mapbox-gl-native#11728.

@cammace
Copy link
Contributor Author

cammace commented May 2, 2018

After internal discussion, offline improvements downstream will make moving the offline downloads on a separate thread little to no performance improvements in our offline plugin.

@cammace cammace closed this as completed May 2, 2018
@LukasPaczos LukasPaczos removed this from the offline-0.2.0 milestone Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
offline-plugin Issues that deal with the offline plugin module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cammace @LukasPaczos