Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluesky?] Refactor into modules for each type of dataset #68

Closed
rclark opened this issue Jan 22, 2015 · 3 comments
Closed

[bluesky?] Refactor into modules for each type of dataset #68

rclark opened this issue Jan 22, 2015 · 3 comments

Comments

@rclark
Copy link
Contributor

rclark commented Jan 22, 2015

Building modules that each deal with a specific type of file could really help this library be more approachable and maintainable. I'm imagining modules which all have methods like getProjection and getExtent, and a single digest() function that chooses the right module + strings together method calls to build a metadata object.

Most of the functions in the current implementation are like getProjection and while sounding generic, contain logic that branches based on filetype anyways.

Implementing this would make adding new features like different mapnik datasource types for topojson and geojson much more straightforward to implement. For example the mess I made in #67.

cc @GretaCB

@rclark rclark changed the title [bluesky] Refactor into modules for each type of dataset [bluesky?] Refactor into modules for each type of dataset Jan 22, 2015
@springmeyer
Copy link
Contributor

👍 refactoring this soon hopefully would help unblock #72

@GretaCB
Copy link
Contributor

GretaCB commented Feb 6, 2015

Refactor PR at #84

@GretaCB
Copy link
Contributor

GretaCB commented Feb 26, 2015

Merged.

@GretaCB GretaCB closed this as completed Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants