Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CleanPolygon call configurable/disable-able #131

Closed
springmeyer opened this issue Jun 29, 2015 · 2 comments
Closed

Make CleanPolygon call configurable/disable-able #131

springmeyer opened this issue Jun 29, 2015 · 2 comments
Milestone

Comments

@springmeyer
Copy link
Contributor

Calling ClipperLib::CleanPolygon may discard tiny polygons at low zooms. This is generally desirable if your priority is reducing vtile sizes. But this may not be desirable in certain situations.

Take for instance: making maps at low zoom levels of polynesian islands.

Here is an example of a MarkersSymbolizer on each polygon when rendering shp->png directly (no vector tile encoding):

nz-1

However when rendered to a vtile and back to an image we loose many of the small islands:

nz-1-actual

After disabling CleanPolygon we regain most of the small islands:

nz-1-actual-noclean

NOTE: area_threshold in these tests was set to 0.0 so the islands are not being thrown away due to that parameter.

One potential solution - for cartographic or other use cases where loosing small polygons is not okay -would be to offer a mode where polygons are collapsed to points rather than thrown away. But in the short term I think the best solution is to provide an option to disable cleaning polygons.

@flippmoke
Copy link
Member

I wonder if this should actually be configurable, because my hunch is that these small islands are invalid polygons.

@flippmoke
Copy link
Member

flippmoke commented Apr 3, 2017

This issue is closed because the CleanPolygon process has been replaced as part of the introduction of wagyu over the angus clipper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants