Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested geoJson properties are copied by reference #215

Open
mrkwanzaa opened this issue Feb 27, 2023 · 0 comments · May be fixed by #216
Open

Nested geoJson properties are copied by reference #215

mrkwanzaa opened this issue Feb 27, 2023 · 0 comments · May be fixed by #216
Labels
enhancement

Comments

@mrkwanzaa
Copy link

When cloning a cluster in _map the assign function only shallow clones an object, copying sub-objects or arrays by reference. This can result in mutations to the original object when the accumulator is mutated in reduce.
@mrkwanzaa mrkwanzaa linked a pull request Feb 27, 2023 that will close this issue
Open
oscarfonts added a commit to geomatico/supercluster that referenced this issue Mar 18, 2024
@oscarfonts
Deep cloning of cluster properties. Closes mapbox#215
5b0a9e1
oscarfonts added a commit to geomatico/supercluster that referenced this issue Mar 18, 2024
@oscarfonts
Deep cloning of cluster properties. Closes mapbox#215
a35173e
oscarfonts added a commit to geomatico/supercluster that referenced this issue Mar 18, 2024
@oscarfonts
Deep cloning of cluster properties. Closes mapbox#215
6b968a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deep clone for cluster mapping mrkwanzaa/supercluster
2 participants
@mourner @mrkwanzaa