Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build progress greater than 100% #268

Closed
bkowshik opened this issue Jul 8, 2016 · 3 comments
Closed

Build progress greater than 100% #268

bkowshik opened this issue Jul 8, 2016 · 3 comments

Comments

@bkowshik
Copy link

bkowshik commented Jul 8, 2016

Running following tippecanoe command:

$ tippecanoe -f -z14 -Z14 -o data.mbtiles data.json

Logs the following from build:

telemetry-clipped-default.mbtiles:1: ignoring dimensions beyond two
For layer 0, using name "telemetryclippeddefault"
Sorting 530141 features
530141 features, 109957661 bytes of geometry, 530141 bytes of metadata, 0 bytes of string pool
  100.4%  14/2832/6560

Question: Why does the progress say 100.4%?

@e-n-f
Copy link
Contributor

e-n-f commented Jul 8, 2016

There is a race condition between multiple tiling threads updating the progress indicator at the same time. I should give each of them its own independent counter so that the total can only lag behind reality instead of getting ahead of it.

@e-n-f
Copy link
Contributor

e-n-f commented Jul 8, 2016

Actually not a race condition, just a math error. Should be fixed in #269

@e-n-f e-n-f closed this as completed Jul 8, 2016
@bkowshik
Copy link
Author

Cool. Thank you @ericfischer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants