Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LineString intersection method #141

Closed
1ec5 opened this issue Mar 30, 2021 · 0 comments · Fixed by #167
Closed

Add LineString intersection method #141

1ec5 opened this issue Mar 30, 2021 · 0 comments · Fixed by #167
Assignees
Labels
improvement Improvement for an existing feature.
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 30, 2021

intersection(_:_:) takes two instances of LineSegment, which is just a type alias for a tuple of two coordinates. This is an unusual type used nowhere else in the library. I think it’s intended to be more efficient than LineString for intersection purposes, but LineString would be more discoverable. We should add a LineString.intersection(with:) method that takes another LineString. This method would be more discoverable and intuitive than the existing intersection(_:_:) method, and we might eventually have an opportunity to make it more generic as part of a protocol once #51 is implemented.

/cc @mapbox/navigation-ios @ZiZasaurus

@1ec5 1ec5 added improvement Improvement for an existing feature. needs estimate labels Mar 30, 2021
@1ec5 1ec5 added this to the v2.1 (beta) milestone Sep 24, 2021
@Udumft Udumft self-assigned this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants