Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And specification on unique IDs? #5

Closed
pramsey opened this issue Apr 14, 2014 · 3 comments
Closed

And specification on unique IDs? #5

pramsey opened this issue Apr 14, 2014 · 3 comments
Milestone

Comments

@pramsey
Copy link

pramsey commented Apr 14, 2014

It feels weird that unique ID is optional, not mandatory, since features across tiles are going to have to be acted on together occasionally for visual coherence. I suppose a good spec finds a balance between optionality and mandatories, but a unique ID per feature seem not unreasonable, so I can know that various areas and boundaries stretching over several tiles are the same feature.

@sgillies
Copy link
Contributor

sgillies commented May 6, 2014

Unless I misunderstand the protobufs, changing id to required will break things: new programs won't be able to use data written by older programs.

This might be the right time for a breaking change. On the other hand, since a protocol for combining clipped features can't be described in protobufs anyway, we could leave it optional and write up proper guidance (SHOULD use id) elsewhere.

@kkaefer
Copy link
Member

kkaefer commented May 8, 2014

Requiring an ID is something that the vector tile creator could guarantee but nothing that the specification should prescribe. Also note that there is no guarantee that IDs have to be unique per tile or in a global dataset.

@flippmoke flippmoke added this to the v2.0 milestone Nov 18, 2015
@flippmoke
Copy link
Member

cdb7b23#diff-9ddbaee0ff4dd86379e37c568367ea05R63 was added in the new v2 pull request in order to clarify unique ids. If there is not any objections around this and the wording of it I will eventually close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants