Migrate examples in android TestApp to Kotlin #416
Conversation
birkskyum
changed the title
birkskyum
force-pushed
the
upgrade-test-app-to-kotlin
branch
from
c0dabda
to
3ec28ac
Compare
|
Thanks @birkskyum. I think Kotlin is the right language for Android. Let's wait with this pull request until we decided on #420. |
birkskyum
force-pushed
the
upgrade-test-app-to-kotlin
branch
from
01557e9
to
e7a3705
Compare
birkskyum
force-pushed
the
upgrade-test-app-to-kotlin
branch
2 times, most recently
from
02dff3b
to
36aa1c9
Compare
|
Do we have some build instructions for this test app? Would like to try it out... |
|
Yes, it's a matter of opening Android Studio in the platform/android directory. Create a virtual device (like rezisable or pixel with a modern API like 31-33) and run the MapboxGLAndroidSDKTestApp. Gradle will have to do a lot of work when you open the repo, so it can take a little while, but apart from that, it's quite few steps. |
|
Great, I will give it a go and ping you if I am stuck... |
birkskyum
force-pushed
the
upgrade-test-app-to-kotlin
branch
from
36aa1c9
to
06de7a5
Compare
…bre/maplibre-gl-native into upgrade-test-app-to-kotlin
birkskyum
changed the title
|
What is the easiest way to review this pull request? The diff seems to be too large for git to recognize that the files were renamed and the code was changed... |
|
The only way as I see it is to run the app before the change, see how each example works, and then apply the change and validate that the example works the same as a practical test. That's how I've done it for each example. |
|
Sure I can do that. I might also just rename the files back to .java and then do a diff... |
|
This is like a first round of porting. Many small changes can be done for each file due to the new capabilities of Kotlin, especially regarding NullPointerExceptions, but that'll be a second round. |
Many of the examples from the TestApp ported 1 to 1 to kotlin.