Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying point and polygon results #86

Closed
souperneon opened this issue Dec 9, 2015 · 8 comments
Closed

Displaying point and polygon results #86

souperneon opened this issue Dec 9, 2015 · 8 comments

Comments

@souperneon
Copy link

  • points get a pin on the map with a tooltip (tooltip can be closed by clicking the 'x')
  • polygons just zoom that map to include the polygon in the viewport with a highlighted boundary and no pin is dropped (nice to have- label for the polygon is highlighted)
@riordan
Copy link
Contributor

riordan commented Dec 9, 2015

We don't have polygon data yet but we will soon! So this is in the not too distant future.

@souperneon
Copy link
Author

I debated adding the 'future' label on this but left it coz those issues never get looked at!
Can't wait :)

@riordan
Copy link
Contributor

riordan commented Dec 9, 2015

Nah; we take the 'future' seriously.

On Dec 9, 2015, at 5:17 PM, Ekta Daryanani notifications@github.com wrote:

I debated adding the 'future' label on this but left it coz those issues never get looked at!
Can't wait :)


Reply to this email directly or view it on GitHub.

@louh
Copy link
Contributor

louh commented Feb 22, 2016

Related info for future reference and questions for debate:

When polygon geometries are available, these will be obtained by requesting from the /place endpoint. Thus, the handle for the /place response needs to also handle displaying the geometry. Currently, displaying locations are handled when a result is selected -- before a place request is made. It may be likely that in the future that all location displaying happens after a /place request, but this introduces potentially lots of requests to be fired, particularly if, when highlighting results, it needs to auto-pan to that location.

  • Do auto-pan to locations require polygon geometry?
  • What if we only requested /place data for non-point layers?
  • If all displays run through the handle for /place, what happens if requests are rate limited?

@dianashk dianashk added this to the Leaflet Geocoder milestone Apr 19, 2016
@louh
Copy link
Contributor

louh commented Mar 7, 2017

This has been resolved with panning to bbox. We do not make /place requests automatically because of the additional traffic overhead, and ask that developers who require /place functionality handle this themselves by adding callbacks to event listeners.

@louh
Copy link
Contributor

louh commented Mar 7, 2017

We should make an example that does this.

@louh louh modified the milestones: 1.8.0, Leaflet Geocoder Mar 7, 2017
@louh
Copy link
Contributor

louh commented Mar 8, 2017

So! /place does not return boundary geometry nor will it in the future. Currently it returns very little of interest, but could return more, and there is no plan from Pelias team to return geometry.

I am working on an example now which will take a selection, and uses it to make a request to WOF for the boundary geometry. Naturally this only works for WOF sources for coarse layers. We should be able to use this to indicate possibility, but since it introduces a separate dependency on another external service for very limited situations, my conclusion is that this is outside of the scope of the geocoder functionality (and perhaps would be better suited for downstream functionality bundles like mapzen.js).

@louh
Copy link
Contributor

louh commented Mar 8, 2017

Added 1798d85

@louh louh closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants