Can disable point or polygon markers by falsy value #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this! But I think whether it the icons should show up should be independent of the marker - since the icons should still appear in the results list. There is a bug right now where the icons don't show up in results even though they should.
|
|
@bdon, is it okay to remove the check for |
|
👌 |
louh
added a commit
that referenced
this pull request
Nov 2, 2015
Can disable point or polygon markers by falsy value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(to discuss)
fix setting "pointIcon" or "polygonIcon" to a falsy value disabling that type of marker
I think these icons should also only show up if "markers" are enabled - double check?