-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't import "historic" WOF neighbourhoods #59
Comments
/cc @thisisaaronland |
Turns out these aren't in unix seconds but in See also: |
I had a crack at this and it seems it's harder than I expected. Basically, we've assumed in the code (all the way through, not just the WOF import code) that visibility of a feature is a function of its parameters and geometry only. Supporting the This isn't a show-stopper, just means that we have to carry through the start and end dates from all neighbourhoods through to the database (which might involve some interesting ways of encoding "year infinity" in the database) and index them and have the tile update tool be more clever about what tiles it considers for updates (it needs to have an idea of the "last time I ran"). Feel free to move it around in the priority list if this change in effort level changes the priority. |
LGTM, let's try it on dev. |
Hmm, I'm still seeing the bunk United States neighbourhood label in Mesa, Arizona: https://whosonfirst.mapzen.com/spelunker/id/85865451/ |
Yeah, needed an update to the mapnik server as well. Once that was done, I forcibly refreshed that one tile: |
I still see it in this tiles (and others)? Caught when they're next updates meaning any of that deprecated records other fields are updated or? That may be a while... does this need a DB migration that effectively reloads all the neighbourhoods? |
That tile might be cached already. The update that I did was pretty hacky, perhaps it can only be seen in the original json: http://vector.dev.mapzen.com/osm/all/15/6219/13165.json We could do a mass-update, but there are so few neighbourhoods which have an inception / cessation that it's probably best to target some sort of one-off update for those. |
Testing this with a new one that's marked deprecated today (
Which is Korblex in Arcata, California:
|
Worked. |
When a WOF record has either the
edtf:cessation
or theedtf:deprecated
, we should treat it the same as a record that has beensuperseded_by
and not import it for tile generation (and if it's been imported in the past, we should remove it).The text was updated successfully, but these errors were encountered: