Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sea and ocean labels in places to water layer #148

Closed
nvkelso opened this issue Aug 26, 2015 · 6 comments
Closed

Move sea and ocean labels in places to water layer #148

nvkelso opened this issue Aug 26, 2015 · 6 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Aug 26, 2015

I'm seeing seas in the "places" layer, but most of the water labels are in water.

@nvkelso nvkelso changed the title Consolodate water labels into a new water or water-labels layer Consolidate water labels into a new water or water-labels layer Aug 26, 2015
@nvkelso
Copy link
Member Author

nvkelso commented Sep 3, 2015

From:
https://github.com/mapzen/vector-datasource/blob/master/queries/places.jinja2#L46

        {% if zoom >= 3 %}, 'sea'{% endif %}

@nvkelso
Copy link
Member Author

nvkelso commented Sep 3, 2015

Also ocean

@nvkelso nvkelso changed the title Consolidate water labels into a new water or water-labels layer Move sea and ocean labels in places to water layer Sep 30, 2015
@nvkelso nvkelso added the ready label Dec 18, 2015
@nvkelso nvkelso added this to the v0.7.0 milestone Dec 18, 2015
@nvkelso
Copy link
Member Author

nvkelso commented Dec 18, 2015

Related: #400.

@nvkelso
Copy link
Member Author

nvkelso commented Jan 15, 2016

Load balancing to v0.8

@nvkelso nvkelso modified the milestones: v0.8.0, v0.7.0 Jan 15, 2016
@nvkelso nvkelso removed the ready label Jan 15, 2016
@nvkelso nvkelso modified the milestones: v0.8.0, v0.7.0 Jan 15, 2016
@nvkelso nvkelso added the ready label Jan 22, 2016
@nvkelso nvkelso removed the ready label Feb 4, 2016
@nvkelso nvkelso modified the milestones: v0.9.0, v0.8.0 Feb 12, 2016
@nvkelso nvkelso added the ready label Feb 24, 2016
@nvkelso nvkelso modified the milestones: v0.9.0, v0.8.0 Feb 24, 2016
@nvkelso nvkelso removed the ready label Feb 24, 2016
@nvkelso nvkelso added this to the v0.10.0 milestone Mar 12, 2016
@nvkelso nvkelso removed this from the v0.8.0 milestone Mar 12, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Mar 23, 2016

Gotchas:

  • ocean and Ocean are equivelant, both should be used in filters.
  • reservoir and Reservoir are equivalent, both should be used in filters.
  • The (capitalized) Natural Earth values don’t seem to be coming thru, but should be, instead they’re being grouped into lake, playa, and ocean.
  • Alkaline Lake and Playa only exist in Natural Earth. Zooming in, your feature may disappear. Beware the desert around Great Salt Lake in Utah!
  • kinds should probably only be lowercase

@nvkelso
Copy link
Member Author

nvkelso commented Apr 20, 2016

Working for as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants