Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The population field in the places layer is a string #230

Closed
rmarianski opened this issue Sep 22, 2015 · 2 comments
Closed

The population field in the places layer is a string #230

rmarianski opened this issue Sep 22, 2015 · 2 comments
Labels
loe low qa complete
Milestone
v0.6.0

Comments

@rmarianski
Copy link
Member

For the places layer, instead of returning back the population as a string, we should coerce to an integer in a transform. This would also simplify the sort function.
@nvkelso
Copy link
Member

nvkelso commented Sep 22, 2015

+1

@nvkelso nvkelso added this to the v0.6.0 milestone Nov 6, 2015
@nvkelso nvkelso added the ready label Nov 20, 2015
This was referenced Nov 30, 2015
Merged
Merged
@nvkelso
Copy link
Member

nvkelso commented Dec 14, 2015

Verified these are ints now instead of strings:
http://vector.mapzen.com/osm/all/11/328/793.topojson?api_key=vector-tiles-HqUVidw
versus prod:
http://vector.dev.mapzen.com/osm/all/11/328/793.topojson

http://vector.mapzen.com/osm/all/7/20/49.topojson?api_key=vector-tiles-HqUVidw
versus prod:
http://vector.dev.mapzen.com/osm/all/7/20/49.topojson

@nvkelso nvkelso closed this as completed Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
loe low qa complete
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
3 participants
@rmarianski @zerebubuth @nvkelso