Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swimming pools in with water #443

Closed
nvkelso opened this issue Dec 14, 2015 · 6 comments
Closed

Add swimming pools in with water #443

nvkelso opened this issue Dec 14, 2015 · 6 comments
Assignees
@zerebubuth
Labels
loe low qa complete
Milestone
v0.7.0

Comments

@nvkelso
Copy link
Member

nvkelso commented Dec 14, 2015

We're not picking up leisure=swimming_pool as a water like feature:
https://www.openstreetmap.org/way/189470798

screen shot 2015-12-13 at 21 52 25
@nvkelso nvkelso added this to the v0.7.0 milestone Dec 14, 2015
@nvkelso
Copy link
Member Author

nvkelso commented Dec 14, 2015

Looks like there are two ways of tagging swimming pools (also: amenity=swimming_pool):
http://wiki.openstreetmap.org/wiki/Tag:amenity%3Dswimming_pool

@nvkelso nvkelso added the ready label Dec 16, 2015
@rmarianski rmarianski self-assigned this Dec 21, 2015
@rmarianski rmarianski mentioned this issue Dec 21, 2015
Merged
@zerebubuth
Copy link
Member

Before:

cupertino-z18-before

After:

cupertino-z18-after

@nvkelso
Copy link
Member Author

nvkelso commented Jan 5, 2016

Preview images look good.

@nvkelso nvkelso assigned zerebubuth and unassigned rmarianski Jan 5, 2016
@zerebubuth zerebubuth assigned nvkelso and unassigned zerebubuth Jan 12, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Jan 13, 2016

@zerebubuth I see this swimming pool at zoom 19 tiles, but not zoom 18 or zoom 17. Can you confirm you see the same pattern?

@nvkelso nvkelso assigned zerebubuth and unassigned nvkelso Jan 13, 2016
@zerebubuth
Copy link
Member

Same issue as before: I forgot to update fastly after the last dev release.

@nvkelso
Copy link
Member Author

nvkelso commented Jan 13, 2016

Verified, pool party!

@nvkelso nvkelso closed this as completed Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerebubuth zerebubuth

Labels
loe low qa complete
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
3 participants
@rmarianski @zerebubuth @nvkelso