Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add man_made features #675

Closed
6 tasks
nvkelso opened this issue Apr 4, 2016 · 5 comments
Closed
6 tasks

Add man_made features #675

nvkelso opened this issue Apr 4, 2016 · 5 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Apr 4, 2016

The following are features which probably get included in buildings or landuse now, but we're not including many nodes (should be added to pois layer).

When it is in building layer, we should prefer the man_made=* value for the kind (over building=*).

Format is:
LINK to osm wiki, EXAMPLE to construct test, recommended MIN_ZOOM value, and COUNT of features.

@nvkelso nvkelso added this to the v0.10.0 milestone Apr 4, 2016
@zerebubuth
Copy link
Member

When there's a building polygon, we should put that in the buildings layer. If it also has POI tags, those get lifted off and added as a centroid in the pois layer. That logic should not change - this is just adding some new man_made types. Please do not change the existing POI / building logic.

@nvkelso
Copy link
Member Author

nvkelso commented Apr 4, 2016

Sounds good, thanks for clarification.

On Apr 4, 2016, at 08:22, Matt Amos notifications@github.com wrote:

When there's a building polygon, we should put that in the buildings layer. If it also has POI tags, those get lifted off and added as a centroid in the pois layer. That logic should not change - this is just adding some new man_made types. Please do not change the existing POI / building logic.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@nvkelso nvkelso added ready and removed ready labels Apr 13, 2016
@nvkelso nvkelso self-assigned this Apr 13, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Apr 14, 2016

Skip silos, those are almost all buildings, and the shape alone should suffice.

@nvkelso
Copy link
Member Author

nvkelso commented Apr 14, 2016

(Adjusted a few of the zooms after validating with more test data.)

@nvkelso
Copy link
Member Author

nvkelso commented Apr 20, 2016

Looking good.

@nvkelso nvkelso removed their assignment Apr 20, 2016
@nvkelso nvkelso closed this as completed May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants