Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DMG functionality by using an external library #2441

Closed
ntindle opened this issue Jun 6, 2024 · 2 comments · Fixed by #2442
Closed

Extend DMG functionality by using an external library #2441

ntindle opened this issue Jun 6, 2024 · 2 comments · Fixed by #2442

Comments

@ntindle
Copy link
Contributor

ntindle commented Jun 6, 2024

Tools like dmgbuild (python) and appdmg (node) for MacOS allow the user to configure the layout of the .dmg drive and add things like this

img of a visually configured dmg

Would you be interested in having that feature for cx_Freeze, and if so, how would you expect it to be integrated? Reimplementation of the existing package (dmgbuild) or using it?

The work to add it on doesn't seem to be that large and with guidance I would be willing to put up a pr

Originally posted by @ntindle in #2438

@ntindle
Copy link
Contributor Author

ntindle commented Jun 6, 2024

I'm not a macOS user, but I knew about dmgbuild and create-dmg, which seem more complete, but more difficult to integrate.
And answering your question, I am happy with your willingness to contribute and I believe that using dmgbuild as a dependency is the best option.
The implementation of bdist_dmg in this case, should be moved from here to a new module.
There a test here that can be moved to new module and enhanced to test the new options.

Message from @marcelotduarte for context

@marcelotduarte
Copy link
Owner

Release 7.2.0 is out!
Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants