-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the new firmware info mechanism #73
Comments
I would give it some time before removing the 70% thingy. Not everyone updates to the newest master all the time. Maybe one or two releases. |
Hhhmm, alright...then indeed I'll need to create this one big if-else probing for |
You could also rely on the |
But then you would need another docker image update |
Build support for nodemcu/nodemcu-firmware#2830 into
build-esp8266
.Set the environment variable
USER_PROLOG
.@HHHartmann do you think it's feasible/acceptable to just remove 70% of the stuff in
build-esp8266
and thereby no longer altering the welcome message for the frozen 1.5.x branch? It would be a relief to get rid of all that code 😉If I only commit this change after the firmware's upcoming master drop it wouldn't affect developers on the master branch.
The text was updated successfully, but these errors were encountered: