From 6144d331c097a943a841ec93378115d7c9d47321 Mon Sep 17 00:00:00 2001 From: MrMuzyk Date: Mon, 5 Feb 2024 09:40:02 +0100 Subject: [PATCH] fix: more styling fixes (#16) * fix: more styling fixes * fix: styling fixes * fix: change headline line height and change questionmark icon size --- src/components/AddPlaidBankAccount.js | 3 ++- .../BankInfo/substeps/Confirmation.tsx | 4 ++-- .../ReimbursementAccount/BankInfo/substeps/Manual.tsx | 4 ++-- .../substeps/BeneficialOwnerCheckUBO.tsx | 4 ++-- .../BeneficialOwnerDetailsFormSubsteps/AddressUBO.tsx | 4 ++-- .../ConfirmationUBO.tsx | 2 +- .../DateOfBirthUBO.tsx | 2 +- .../LegalNameUBO.tsx | 2 +- .../SocialSecurityNumberUBO.tsx | 4 ++-- .../substeps/CompanyOwnersListUBO.tsx | 4 ++-- .../BusinessInfo/substeps/AddressBusiness.tsx | 2 +- .../BusinessInfo/substeps/ConfirmationBusiness.tsx | 2 +- .../substeps/IncorporationDateBusiness.tsx | 2 +- .../substeps/IncorporationStateBusiness.tsx | 3 ++- .../BusinessInfo/substeps/NameBusiness.tsx | 2 +- .../BusinessInfo/substeps/PhoneNumberBusiness.tsx | 2 +- .../BusinessInfo/substeps/TaxIdBusiness.tsx | 2 +- .../substeps/TypeBusiness/TypeBusiness.tsx | 2 +- .../BusinessInfo/substeps/WebsiteBusiness.tsx | 2 +- .../substeps/ConfirmAgreements.tsx | 2 +- .../ConnectBankAccount/ConnectBankAccount.tsx | 1 - .../ConnectBankAccount/components/Enable2FACard.tsx | 1 + .../ConnectBankAccount/components/FinishChatCard.tsx | 2 +- .../ReimbursementAccount/PersonalInfo/HelpLinks.tsx | 2 ++ .../PersonalInfo/substeps/Address.tsx | 4 ++-- .../PersonalInfo/substeps/Confirmation.tsx | 2 +- .../PersonalInfo/substeps/DateOfBirth.tsx | 2 +- .../PersonalInfo/substeps/FullName.tsx | 2 +- .../PersonalInfo/substeps/SocialSecurityNumber.tsx | 4 ++-- src/styles/index.ts | 11 ++++++++++- 30 files changed, 49 insertions(+), 36 deletions(-) diff --git a/src/components/AddPlaidBankAccount.js b/src/components/AddPlaidBankAccount.js index 1f726e409bb2..00cefa17277c 100644 --- a/src/components/AddPlaidBankAccount.js +++ b/src/components/AddPlaidBankAccount.js @@ -280,12 +280,13 @@ function AddPlaidBankAccount({ return ( {translate('bankAccount.chooseAnAccount')} - {!_.isEmpty(text) && {text}} + {!_.isEmpty(text) && {text}} {bankName} diff --git a/src/pages/ReimbursementAccount/BankInfo/substeps/Confirmation.tsx b/src/pages/ReimbursementAccount/BankInfo/substeps/Confirmation.tsx index 0f05428d5ed9..e9edc9329eec 100644 --- a/src/pages/ReimbursementAccount/BankInfo/substeps/Confirmation.tsx +++ b/src/pages/ReimbursementAccount/BankInfo/substeps/Confirmation.tsx @@ -51,8 +51,8 @@ function Confirmation({reimbursementAccount, reimbursementAccountDraft, onNext, style={[styles.pt0]} > - {translate('bankAccount.letsDoubleCheck')} - {translate('bankAccount.thisBankAccount')} + {translate('bankAccount.letsDoubleCheck')} + {translate('bankAccount.thisBankAccount')} {setupType === CONST.BANK_ACCOUNT.SUBSTEP.MANUAL && ( - {translate('bankAccount.manuallyAdd')} - {translate('bankAccount.checkHelpLine')} + {translate('bankAccount.manuallyAdd')} + {translate('bankAccount.checkHelpLine')} - {title} - {translate('beneficialOwnerInfoStep.regulationRequiresUsToVerifyTheIdentity')} + {title} + {translate('beneficialOwnerInfoStep.regulationRequiresUsToVerifyTheIdentity')} - {translate('beneficialOwnerInfoStep.enterTheOwnersAddress')} - {translate('common.noPO')} + {translate('beneficialOwnerInfoStep.enterTheOwnersAddress')} + {translate('common.noPO')} - {translate('beneficialOwnerInfoStep.letsDoubleCheck')} + {translate('beneficialOwnerInfoStep.letsDoubleCheck')} - {translate('beneficialOwnerInfoStep.enterTheDateOfBirthOfTheOwner')} + {translate('beneficialOwnerInfoStep.enterTheDateOfBirthOfTheOwner')} {/* @ts-expect-error TODO: Remove this once DatePicker (https://github.com/Expensify/App/issues/25148) is migrated to TypeScript. */} InputComponent={DatePicker} diff --git a/src/pages/ReimbursementAccount/BeneficialOwnerInfo/substeps/BeneficialOwnerDetailsFormSubsteps/LegalNameUBO.tsx b/src/pages/ReimbursementAccount/BeneficialOwnerInfo/substeps/BeneficialOwnerDetailsFormSubsteps/LegalNameUBO.tsx index 8f562fd71d4c..2aae8d8d19f5 100644 --- a/src/pages/ReimbursementAccount/BeneficialOwnerInfo/substeps/BeneficialOwnerDetailsFormSubsteps/LegalNameUBO.tsx +++ b/src/pages/ReimbursementAccount/BeneficialOwnerInfo/substeps/BeneficialOwnerDetailsFormSubsteps/LegalNameUBO.tsx @@ -52,7 +52,7 @@ function LegalNameUBO({reimbursementAccountDraft, onNext, isEditing, beneficialO style={[styles.mh5, styles.flexGrow1]} submitButtonStyles={[styles.pb5, styles.mb0]} > - {translate('beneficialOwnerInfoStep.enterLegalFirstAndLastName')} + {translate('beneficialOwnerInfoStep.enterLegalFirstAndLastName')} - {translate('beneficialOwnerInfoStep.enterTheLast4')} - {translate('beneficialOwnerInfoStep.dontWorry')} + {translate('beneficialOwnerInfoStep.enterTheLast4')} + {translate('beneficialOwnerInfoStep.dontWorry')} - {translate('beneficialOwnerInfoStep.letsDoubleCheck')} + {translate('beneficialOwnerInfoStep.letsDoubleCheck')} {translate('beneficialOwnerInfoStep.regulationRequiresUsToVerifyTheIdentity')} - {`${translate('beneficialOwnerInfoStep.owners')}:`} + {`${translate('beneficialOwnerInfoStep.owners')}:`} {isUserUBO && ( - {translate('businessInfoStep.enterYourCompanysAddress')} + {translate('businessInfoStep.enterYourCompanysAddress')} {translate('common.noPO')} - {translate('businessInfoStep.letsDoubleCheck')} + {translate('businessInfoStep.letsDoubleCheck')} - {translate('businessInfoStep.selectYourCompanysIncorporationDate')} + {translate('businessInfoStep.selectYourCompanysIncorporationDate')} {/* @ts-expect-error TODO: Remove this once DatePicker (https://github.com/Expensify/App/issues/25148) is migrated to TypeScript. */} InputComponent={DatePicker} diff --git a/src/pages/ReimbursementAccount/BusinessInfo/substeps/IncorporationStateBusiness.tsx b/src/pages/ReimbursementAccount/BusinessInfo/substeps/IncorporationStateBusiness.tsx index 7934934f086e..e2ef3a5a69e4 100644 --- a/src/pages/ReimbursementAccount/BusinessInfo/substeps/IncorporationStateBusiness.tsx +++ b/src/pages/ReimbursementAccount/BusinessInfo/substeps/IncorporationStateBusiness.tsx @@ -46,8 +46,9 @@ function IncorporationStateBusiness({reimbursementAccount, onNext, isEditing}: I validate={validate} onSubmit={handleSubmit} style={[styles.mh0, styles.flexGrow1]} + submitButtonStyles={[styles.p5, styles.mb0]} > - {translate('businessInfoStep.pleaseSelectTheStateYourCompanyWasIncorporatedIn')} + {translate('businessInfoStep.pleaseSelectTheStateYourCompanyWasIncorporatedIn')} - {translate('businessInfoStep.enterTheNameOfYourBusiness')} + {translate('businessInfoStep.enterTheNameOfYourBusiness')} - {translate('businessInfoStep.enterYourCompanysPhoneNumber')} + {translate('businessInfoStep.enterYourCompanysPhoneNumber')} - {translate('businessInfoStep.enterYourCompanysTaxIdNumber')} + {translate('businessInfoStep.enterYourCompanysTaxIdNumber')} - {translate('businessInfoStep.selectYourCompanysType')} + {translate('businessInfoStep.selectYourCompanysType')} - {translate('businessInfoStep.enterYourCompanysWebsite')} + {translate('businessInfoStep.enterYourCompanysWebsite')} {translate('common.websiteExample')} - {translate('completeVerificationStep.confirmAgreements')} + {translate('completeVerificationStep.confirmAgreements')} {translate('connectBankAccountStep.letsChatText')} diff --git a/src/pages/ReimbursementAccount/PersonalInfo/HelpLinks.tsx b/src/pages/ReimbursementAccount/PersonalInfo/HelpLinks.tsx index 252e35584a96..e5737996d7d6 100644 --- a/src/pages/ReimbursementAccount/PersonalInfo/HelpLinks.tsx +++ b/src/pages/ReimbursementAccount/PersonalInfo/HelpLinks.tsx @@ -24,6 +24,8 @@ function HelpLinks({containerStyles}: HelpLinkProps) { diff --git a/src/pages/ReimbursementAccount/PersonalInfo/substeps/Address.tsx b/src/pages/ReimbursementAccount/PersonalInfo/substeps/Address.tsx index a5346da27184..6af6786eccc9 100644 --- a/src/pages/ReimbursementAccount/PersonalInfo/substeps/Address.tsx +++ b/src/pages/ReimbursementAccount/PersonalInfo/substeps/Address.tsx @@ -76,8 +76,8 @@ function Address({reimbursementAccount, onNext, isEditing}: AddressProps) { style={[styles.mh5, styles.flexGrow1]} > - {translate('personalInfoStep.enterYourAddress')} - {translate('common.noPO')} + {translate('personalInfoStep.enterYourAddress')} + {translate('common.noPO')} - {translate('personalInfoStep.letsDoubleCheck')} + {translate('personalInfoStep.letsDoubleCheck')} - {translate('personalInfoStep.enterYourDateOfBirth')} + {translate('personalInfoStep.enterYourDateOfBirth')} {/* @ts-expect-error TODO: Remove this once DatePicker (https://github.com/Expensify/App/issues/25148) is migrated to TypeScript. */} InputComponent={DatePicker} diff --git a/src/pages/ReimbursementAccount/PersonalInfo/substeps/FullName.tsx b/src/pages/ReimbursementAccount/PersonalInfo/substeps/FullName.tsx index 62218f7e2774..62ec4ea9b9eb 100644 --- a/src/pages/ReimbursementAccount/PersonalInfo/substeps/FullName.tsx +++ b/src/pages/ReimbursementAccount/PersonalInfo/substeps/FullName.tsx @@ -65,7 +65,7 @@ function FullName({reimbursementAccount, onNext, isEditing}: FullNameProps) { submitButtonStyles={[styles.pb5, styles.mb0]} > - {translate('personalInfoStep.enterYourLegalFirstAndLast')} + {translate('personalInfoStep.enterYourLegalFirstAndLast')} - {translate('personalInfoStep.enterTheLast4')} - {translate('personalInfoStep.dontWorry')} + {translate('personalInfoStep.enterTheLast4')} + {translate('personalInfoStep.dontWorry')} interactiveStepHeaderStepButton: { width: 40, height: 40, - borderWidth: 1, + borderWidth: 2, borderRadius: 20, borderColor: theme.borderFocus, justifyContent: 'center', @@ -4369,6 +4369,15 @@ const styles = (theme: ThemeColors) => color: theme.text, textAlignVertical: 'center', }, + + textHeadlineLineHeightXXL: { + ...headlineFont, + ...whiteSpace.preWrap, + color: theme.heading, + fontSize: variables.fontSizeXLarge, + lineHeight: variables.lineHeightXXLarge, + }, + colorSchemeStyle: (colorScheme: ColorScheme) => ({colorScheme}), updateAnimation: {