Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add Musllinux wheels to workflow (PEP 656 approved) #7

Closed
DeadEnded opened this issue Jul 21, 2022 · 5 comments
Closed

Request: Add Musllinux wheels to workflow (PEP 656 approved) #7

DeadEnded opened this issue Jul 21, 2022 · 5 comments

Comments

@DeadEnded
Copy link

Hello again!

Back when I was making my custom component, we had some discussions where I learned about the wheels, etc.
You had mentioned there was a PEP for supporting musl wheels #3 (comment).

... and it was approved a while ago pypa/auditwheel#305.

Recently the program I build my component for updated to python 3.10, and with the support of musllinux wheels they have archived their custom wheels as they are no longer need. This means my component is temporarily broken! Luckily there is an easy fix... I need musllinux wheels to be built and publish along with the manylinux wheels.

SO - I know that doesn't sound difficult as in theory it is a workflow update (and possibly debugging any issues). I took a look at your workflow to see if I could help and do a PR to get them added... I followed your process flow and see where you use a container from RalfG... and in that repo there is a request to add musllinux support RalfG/python-wheels-manylinux-build#52.

So long story short... can you look into adding musllinux wheels to your workflow?
I understand that potentially you will want to wait for RalfG to add support so you can use a similar process as your manylinux flow.
If there is anything I can do to help, let me know and I will see what I can do!

Thanks!
Deadend

@mark9064
Copy link
Owner

Hi again! Good to see that musl wheels have progressed along to being possible now. I'd definitely like to build them, but as you rightly spotted it looks like the CI action I'm using doesn't support it yet. The PR has been there since mid June which isn't too encouraging. Maybe I'll end up switching to a different script, not sure yet.

Thanks for the heads up and research, will keep you updated on where I get with this. There might be further issues as I've never tried this before, but hopefully it's doable :D

@mark9064
Copy link
Owner

RalfG/python-wheels-manylinux-build#52 just got merged so hopefully I can get this working soon

@DeadEnded
Copy link
Author

Fantastic!
Looks like this might not be too far away then!

@mark9064
Copy link
Owner

Should be available with the 2.1.3 release! Let me know how it goes

@DeadEnded
Copy link
Author

Looks great!
Just restarted my container, and it installed without any issues.
Awesome job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants