-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renderer.html() is not invoked if HTML is not preceded by a newline #1601
Closed
octogonz opened this issue
Feb 12, 2020
· 2 comments
· Fixed by #1602, #1616, qubyte/qubyte-codes#212, geraintwhite/markdown-templator#17 or qubyte/qubyte-codes#214
Closed
Renderer.html() is not invoked if HTML is not preceded by a newline #1601
octogonz opened this issue
Feb 12, 2020
· 2 comments
· Fixed by #1602, #1616, qubyte/qubyte-codes#212, geraintwhite/markdown-templator#17 or qubyte/qubyte-codes#214
Labels
category: inline elements
L1 - broken
Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Comments
UziTech
added
category: inline elements
L1 - broken
Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
labels
Feb 12, 2020
Thank you for reporting this. It should be fixed in #1602 |
Awesome, thanks very much! 😁 |
This was referenced Mar 21, 2020
This was referenced Mar 30, 2020
This was referenced Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: inline elements
L1 - broken
Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Describe the bug
The
renderer
option allows a custom renderer to intercept various markdown elements before the output is written. However, these events do not work correctly for HTML markdown expressions:If HTML markdown is not immediately preceded by a blank line, then the
Renderer.html()
event is skipped -- even though the content is ultimately rendered as HTML. This is a bug.To Reproduce
Example input with CORRECT output:
Example input with INCORRECT output:
Expected behavior
The
Renderer.html()
event SHOULD be invoked for both of the above inputs. The newline should not matter, because the markup is rendered as HTML either way.The text was updated successfully, but these errors were encountered: