Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that src is a string and throw useful error #934

Closed
adius opened this issue Sep 2, 2017 · 0 comments · Fixed by #682
Closed

Check that src is a string and throw useful error #934

adius opened this issue Sep 2, 2017 · 0 comments · Fixed by #682
Labels
help wanted L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@adius
Copy link

adius commented Sep 2, 2017

Currently it prints TypeError: src.replace is not a function if you try to pass a buffer.
Not very helpful.

Not the first who got confused: #867
@joshbruce joshbruce added help wanted L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue labels Dec 1, 2017
@Feder1co5oave Feder1co5oave mentioned this issue Jan 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw error on non-string input Feder1co5oave/marktex
2 participants
@adius @joshbruce