-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task list can't be resolve, is there a bug or a feature? #952
Comments
Do you mean bower or browser? Not sure I follow exactly what's expected versus what's being received. |
browser |
The expectation would be something more like this, yeah: <ul>
<li><input type=”checkbox”><label>Hello</label></li>
</ul> Yeah? |
In github, it will be like this: <ul class="contains-task-list">
<li class="task-list-item">
<input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Hello</li>
</ul> |
@driftluo: Thanks for that. Think we would leave out the classes. Basically, give back the input and type. From an HTML perspective, I don't place a lot fo form controls outside of forms; so, is the GitHub markup accessible (what's the experience like for a blind person, for example). @UziTech: Thoughts? |
I'm not sure that would be in scope for this package. Maybe if we add extensions like markdown-it. Seems like you would want to use markdown-it-checkbox. |
I added a simple fix for this locally, without altering marked('- [ ] x')
.replace(/(<li>)\[ \](\s)/g,'$1<input type="checkbox" />$2'))
.replace(/(<li>)\[x\](\s)/g,'$1<input type="checkbox" checked="checked" />$2'); I am also not sure if it is a good thing to change this behavior. Some implementations might depend on how |
See #982 |
when I use in brower,
marked.js
is inmarked
project'slib
folderand there is same issue on https://github.com/8fold/marked
@8fold
The text was updated successfully, but these errors were encountered: