Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support combined query with SPARQL #300

Closed
wooldridge opened this issue Sep 30, 2016 · 2 comments
Closed

Support combined query with SPARQL #300

wooldridge opened this issue Sep 30, 2016 · 2 comments

Comments

@wooldridge
Copy link
Contributor

Support combined query with SPARQL by adding functionality to the graphs.sparql() method.

Use the existing "documentQuery" parameter to pass in the qtext, structured query, and options information in the combined query form.

The SPARQL part of the query would still be passed in via the "query" parameter on the graphs.sparql() method (not as a "sparql" property in the combined query).

The Node.js queries end up as a combination queries under the hood eventually. So sending things in that way via "documentQuery" should involve a pass-through of sorts.

@wooldridge wooldridge added this to the 9.0-ea4 milestone Sep 30, 2016
@wooldridge wooldridge self-assigned this Sep 30, 2016
@wooldridge wooldridge modified the milestones: 9.0-1, 9.0-ea4 Oct 21, 2016
@wooldridge wooldridge modified the milestones: 9.0-2, 9.0-1 Feb 2, 2017
@wooldridge wooldridge modified the milestones: 9.0-3, 9.0-2 May 10, 2017
@naliniprakash naliniprakash modified the milestones: 9.0-3, 9.0-4 Jul 24, 2017
@wooldridge wooldridge added test and removed new labels Oct 25, 2017
@wooldridge wooldridge assigned ayuwono and unassigned wooldridge Oct 25, 2017
@wooldridge
Copy link
Contributor Author

@ayuwono, it turns out this wasn't a feature to implement since if you put a combined query into the 'docQuery' parameter of graphs#sparql(), the combined query is handled correctly.

I added some tests for using combined query in test-basic, see caa8b4a. I didn't see any such tests in test-complete. You should probably add some there if they aren't there already.

Note that this is related to #437, a documentation bug.

@ayuwono ayuwono added ship and removed test labels Nov 27, 2017
@ayuwono ayuwono removed their assignment Nov 27, 2017
@ayuwono
Copy link
Contributor

ayuwono commented Nov 27, 2017

Verified passed and added tests

@ayuwono ayuwono closed this as completed Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants