Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification component does not disappear correctly. #6928

Closed
wbojaume opened this issue Dec 2, 2021 · 2 comments · Fixed by #6929
Closed

Notification component does not disappear correctly. #6928

wbojaume opened this issue Dec 2, 2021 · 2 comments · Fixed by #6929
Labels

Comments

@wbojaume
Copy link
Contributor

wbojaume commented Dec 2, 2021

What you were expecting:
The notification component will disappear when there are no notifications to display, preventing the Snakbar component from covering a part of the interface.
When a form is saved correctly, all notifications will be output, not just the first one.

What happened instead:
The Notification component remains with visibility: hidden when there is no notification to display covering a part of the interface.
When you save a form correctly several times, the notification only appears the first time.

Steps to reproduce:
For example, if you successfully save an edit form, the notification will appear. When the notification is hidden, the Notification component will remain covering the interface.
If we successfully save the form a second time, the notification will not appear.

Related code:

In this example, using react-admin version 3.12.4, the problem can be reproduced, and it occurs up to the latest version.
https://codesandbox.io/s/github/marmelab/react-admin/tree/master/examples/simple

Other information:
ezgif-2-b11ffbeb7661

Environment

  • React-admin version: 3.19.2
  • Last version that did not exhibit the issue (if applicable): not found
  • React version: 17.0
  • Browser: Firefox 95.0b8
  • Stack trace (in case of a JS error): no
@WiXSL
Copy link
Contributor

WiXSL commented Dec 4, 2021

Reproduced. Thanks

@fzaninotto
Copy link
Member

Duplicate of #6901

@fzaninotto fzaninotto marked this as a duplicate of #6901 Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants