Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer override SimpleFormIterator styles #7629

Closed
andrico1234 opened this issue May 4, 2022 · 1 comment · Fixed by #7630
Closed

Can no longer override SimpleFormIterator styles #7629

andrico1234 opened this issue May 4, 2022 · 1 comment · Fixed by #7630
Labels

Comments

@andrico1234
Copy link
Contributor

What you were expecting:
In RA v3 we were able to override the SimpleFormIterator styles from within our Theme component, but it seems that with the upgrade to v4, this is something we can no longer do

You can see from the repro case that we're applying styles to both the RaEdit component RaSimpleFormIterator. The styles are being applied to the Edit form, but none are being applied to the SimpleFormIterator.

I've also tried a number of different selectors and they don't work.

I'll be happy to open a PR to resolve this. I imagine that it was a small oversight, and would be a straight forward fix

  • React-admin version:
  • Last version that did not exhibit the issue (if applicable):
  • React version:
  • Browser:
  • Stack trace (in case of a JS error):
@slax57
Copy link
Contributor

slax57 commented May 4, 2022

Thanks for submitting this! 🙂
I'll just wait for another member of the team to validate your PR and we will be good to go!

@djhi djhi closed this as completed in #7630 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants