Merge pull request #38 from martincostello/Fix-CVE-List

Fix empty CVE list header
martincostello · Mar 2, 2021 · c25755a · c25755a
2 parents df25ab1 + e20f1bd
commit c25755a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -110,10 +110,12 @@ class DotNetSdkUpdater {
             if (versions.current.security && versions.current.securityIssues.length > 0) {
                 issues = issues.filter(issue => versions.current.securityIssues.findIndex(other => other.id === issue.id) < 0);
             }
-            body += `\n\nThis release includes fixes for the following security issue(s):`;
-            issues.forEach(issue => {
-                body += `\n  * [${issue.id}](${issue.url})`;
-            });
+            if (issues.length > 0) {
+                body += `\n\nThis release includes fixes for the following security issue(s):`;
+                issues.forEach(issue => {
+                    body += `\n  * [${issue.id}](${issue.url})`;
+                });
+            }
         }
         // TODO Update to support GHE
         body += `\n\nThis pull request was auto-generated by [GitHub Actions](https://github.com/${this.options.repo}/actions/runs/${this.options.runId}).`;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "update-dotnet-sdk",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "private": true,
   "description": "A GitHub Action that updates the .NET SDK.",
   "main": "lib/update-dotnet-sdk.js",

diff --git a/src/DotNetSdkUpdater.ts b/src/DotNetSdkUpdater.ts
@@ -121,10 +121,12 @@ export class DotNetSdkUpdater {
         issues = issues.filter(issue => versions.current.securityIssues.findIndex(other => other.id === issue.id) < 0);
       }
 
-      body += `\n\nThis release includes fixes for the following security issue(s):`;
-      issues.forEach(issue => {
-        body += `\n  * [${issue.id}](${issue.url})`;
-      });
+      if (issues.length > 0) {
+        body += `\n\nThis release includes fixes for the following security issue(s):`;
+        issues.forEach(issue => {
+          body += `\n  * [${issue.id}](${issue.url})`;
+        });
+      }
     }
 
     // TODO Update to support GHE