Refactor inline scripts #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
martincostello
commented
Sep 8, 2023
•
martincostello
commented
- Pass values into inline scripts with environment variables.
- Simplify inline scripts to remove duplication.
- Fix warning about possibly invalid output access.
- Update the test workflow to consume from code, rather than via the repository/tag.
- Pass values into inline scripts with environment variables. - Simplify inline scripts to remove duplication. - Fix warning about possibly invalid output access.
martincostello
added
enhancement
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 2 2
Lines 348 348
Branches 66 66
=======================================
Hits 309 309
Misses 32 32
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Use the workflow locally, rather than from `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.