Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop tracking and ignore Carthage dir #340

Closed
phatblat opened this issue Mar 28, 2021 · 4 comments · Fixed by #341
Closed

Stop tracking and ignore Carthage dir #340

phatblat opened this issue Mar 28, 2021 · 4 comments · Fixed by #341
Assignees
@chris-araman
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.

Comments

@phatblat
Copy link
Member

Splitting out from #334

Regarding Carthage, I'm not a fan of checking in copies of dependencies' source but I've left it that way ever since #169 because that was such a nightmare with me trying to get CocoaPods to work before @tonyarnold rescued the switch away from the latent CocoaSeeds. Curious about your thoughts on ignoring the Carthage/ dir since the scripts use the tool to bootstrap anyway.

I agree that the committed copies are awkward. I'm for removing them and adding them to .gitignore, or replacing them with submodules if Carthage supports that.
@phatblat phatblat added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Mar 28, 2021
@chris-araman
Copy link
Contributor

@phatblat, I can pick this up if you haven't started on it yet.

@chris-araman chris-araman self-assigned this Mar 29, 2021
@phatblat
Copy link
Member Author

Go for it 👍🏻

@chris-araman
Copy link
Contributor

It sounds like --use-submodules is only worth the extra tracking if we intend to modify the dependencies in-place and push changes upstream. I don't know that that's likely, so I'll opt for the .gitignore solution instead.

@chris-araman chris-araman mentioned this issue Mar 29, 2021
Merged
@phatblat
Copy link
Member Author

Yeah, pinning to a fork of a dependency is not ideal. I prefer to work with the maintainers and get fixes & features into the mainline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-araman chris-araman

Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

📦 Remove sources of Carthage dependencies
2 participants
@phatblat @chris-araman