Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate if it possible to split classes shared with Netdroid #513

Closed
masesdevelopers opened this issue Aug 7, 2024 · 0 comments · Fixed by #519 or #520
Closed

Evaluate if it possible to split classes shared with Netdroid #513

masesdevelopers opened this issue Aug 7, 2024 · 0 comments · Fixed by #519 or #520
Assignees
Labels
enhancement New feature or request java Pull requests that update Java code JNet JNet related issue JNetReflector JNetReflector related issue .NET Pull requests that update .net code

Comments

@masesdevelopers
Copy link
Contributor

masesdevelopers commented Aug 7, 2024

Two options were identified:

* **submodule**:

  * link JNet repository with a submodule
  * remove copied classes and link them to the submodule folder
  * for JVM side the best way is to create symlinks otherwise, from current knowledge, Maven is not able to compile classes outside pom.xml subfolders

The previous option in any case do not guarantee that changes on JNet side are completely available because, in case of new classes, the Netdroid project shall be reviewed to check if something is missing.

* **request a change to JNet**: maybe JNet project, instead to have all classes in the same folder, can create different folders
  
  * one, ore more, folders with the common classes: containing, at least, the classes JNetReflector expects to be available
  * other folders with remaining classes specific to the project

The previous needs a request to be opened on JNet project.

Originally posted by @masesdevelopers in masesgroup/netdroid#76 (comment)

@masesdevelopers masesdevelopers self-assigned this Aug 7, 2024
@masesdevelopers masesdevelopers added enhancement New feature or request JNet JNet related issue JNetReflector JNetReflector related issue .NET Pull requests that update .net code java Pull requests that update Java code labels Aug 7, 2024
@masesdevelopers masesdevelopers linked a pull request Aug 30, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java Pull requests that update Java code JNet JNet related issue JNetReflector JNetReflector related issue .NET Pull requests that update .net code
Projects
None yet
1 participant