Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dynamic context field from ReactComponent #104

Open
elsassph opened this issue May 8, 2018 · 4 comments
Open

Remove Dynamic context field from ReactComponent #104

elsassph opened this issue May 8, 2018 · 4 comments
Labels
enhancement

Comments

@elsassph
Copy link
Contributor

elsassph commented May 8, 2018 •
edited
Loading

ReactComponent has a var context:Dynamic variable.

It's better to define it in your ReactComponent subclass as needed, with the right typing.
@kLabz
Copy link
Contributor

kLabz commented May 8, 2018

Did you take a look at the new context API? (I didn't)

@elsassph
Copy link
Contributor Author

elsassph commented May 8, 2018

Not in detail but it essentially looks like a HOC for getting the context value. If anything it justifies even more to remove the field.

@kLabz
Copy link
Contributor

kLabz commented May 18, 2018

Should we just add @:deprecated for a few versions? (or until v2.0 with new jsx and without the refs API)

I have no idea if anyone is actually using it.

@elsassph
Copy link
Contributor Author

Yeah we could mark everything deprecated and remove in a 2.x

@kLabz kLabz mentioned this issue May 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elsassph @kLabz