Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

narrow region's label is clipped #166

Closed
carmacleod opened this issue May 17, 2018 · 2 comments
Closed

narrow region's label is clipped #166

carmacleod opened this issue May 17, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@carmacleod
Copy link

If a landmark region is narrow, the region label is clipped (see screenshot).
Not sure if it makes sense to allow it to extend beyond the border of the region.

The region in the screen shot below has the label "Sidebar" and it is a "navigation" region:
image

@matatk matatk added this to the 2.3.1 milestone May 17, 2018
@matatk matatk self-assigned this May 17, 2018
@matatk matatk added the bug label May 17, 2018
@matatk
Copy link
Owner

matatk commented May 17, 2018

Wow, you are good at finding these sorts of things and suggesting improvements—thanks :-).

It seems like something that should be addressed in some way. One of those "why didn't I think of that?" moments, though something similar did come up in my testing (but not as pronounced, so I moved on).

It'd be trivial to determine if the border area is big enough to contain the label. The slightly trickier bit is what to do about it if not (e.g. keep the text where it is, or flow it outside of the border). I'll do some research and if there's a reliable way to detect if the thing is off-screen, then that seems like the way to go.

Alternatively, if the label is too big, it could simply be omitted.

@carmacleod
Copy link
Author

Yeah, I didn't really have a good answer. In our case, turning the label sideways and placing it on the bottom of the region would make sense, but that is likely a ridiculous thing to do! ;)

For grins, here's a mockup. :)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants