Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Support debug builds; build refactoring #279

Merged
merged 11 commits into from
Mar 19, 2019
Merged

build: Support debug builds; build refactoring #279

merged 11 commits into from
Mar 19, 2019

Conversation

matatk
Copy link
Owner

@matatk matatk commented Mar 19, 2019

As mentioned in #271, this adds support for making debug builds.

  • Use yargs to improve options-handling in the build script.
  • Simplify the npm scripts back to building/cleaning the extension for all browsers.
  • Remove the "build:all:quick" script in favour of just calling the build script directly on the CLI.
  • Remove the npm clean scripts; most of this is now done in the build script, which now has a clean mode.
  • Support debug builds (in which console.timeStamp() calls are made).
  • Update the README accordingly.

@matatk
Clarify purpose of code inclusion in build script
2f8a34d
@matatk
Convert build script to use yargs for options-handling
c5c1df0 
This neatens the code now and paves the way to adding extra options, such as debugging.
@matatk
Simplify package.json scripts
2eeb76a
@matatk
Remove rimraf as top-level dependency
12335b0
@matatk
Update package lock
820ade0
@matatk
Update README and build script help
0862429 
* Update README to reflect (most of the) build script changes.
* Improve the help generated by the build script - mention cleaning.
@matatk
Cleaning; Docs
7f50cec 
* Improve code organisation in build script.
* Add support for only-cleaning to the build script.
* Add a "clean:builds" command to package.json - seemed the cleanest way possible.
* Reflect cleaning in REAME.
* Improve docs in README.
* Move explanation of Chrome test release from README to build script help info.
@matatk
Docs
f25f3ad 
* Remove incorrect mention of how to get help on the build script.
* Remove clean:cache script as it relied on now-not-top-level rimraf dependency.
@matatk
Build and Docs
b6e7de0 
* Go back to "build:all" for the public-facing (package.json) build command.
* Simplify main README build docs.
* Mention advanced build script use in README, with absence-of-tests warning.
* Improve help in build script.
@matatk
Build script cleanup
1352f8b 
* Re-organise code for clarity.
* Keep the global testMode variable as it is the simplest approach.
@matatk
Support debug builds
bfd037e
@matatk matatk changed the title Support debug builds and build refactoring build: Support debug builds; build refactoring Mar 19, 2019
@matatk matatk merged commit 48e5aeb into master Mar 19, 2019
@matatk matatk deleted the support-debug-builds-and-build-refactoring branch March 19, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matatk