Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught error: Extension context invalidated #305

Closed
carmacleod opened this issue Mar 25, 2019 · 3 comments
Closed

Uncaught error: Extension context invalidated #305

carmacleod opened this issue Mar 25, 2019 · 3 comments

Comments

@carmacleod
Copy link

Similar to #131, maybe?
Was definitely seeing #127.
Not sure if this SO is relevant/helpful?

image

Note that I uninstalled the extension (kind of coincidentally, but suspecting that it was causing #127) on the same day as the Mar 22 update, so I haven't had a chance to try the update yet, but I will reinstall and run with it for a few days, and report back. I just wanted to show where the error happens, in case it's helpful.

@matatk
Copy link
Owner

matatk commented Mar 25, 2019

Sorry about this one and thanks for your detailed report. I already found and fixed it in development in #296, though it's not in a release yet (looks like enough has been changed recently to make a new release, however, so I can do that this evening).

This shouldn't be causing any performance issues such as #127. My understanding is that the guarding implemented around the mutation observer has been working well. Since then, the scanning code has got faster—though more significantly, and very recently in #269, the number of scans has been reduced even further (though the implementation of #269 caused #296—oops :-)).

I'll mark this as a dupliate for now, but leave it open until you're able to test a new release.

If you are finding any performance issues, and are able to share specific URLs, please let me know via a separate issue. I've been concentrating recently on providing more info as to what's going on with changes to dynamic pages, and am hoping that, if there are more things that can be put in place in this area, that will help in finding them.

@matatk
Copy link
Owner

matatk commented Mar 25, 2019

Version 2.5.5 is now out and has propogated to my Chrome, so it should be with you soon if not already. Just re-loading the extension won't work though, as the previous content script is still knocking around in there. But after you quit and re-open Chrome you shouldn't have this problem anymore.

@carmacleod
Copy link
Author

Haven't seen this since updating. :)
Closing issue.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants