Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Dropping pyenv in favor of python section #112

Open
1 of 2 tasks
matchai opened this issue Nov 25, 2018 · 5 comments
Open
1 of 2 tasks

Dropping pyenv in favor of python section #112

matchai opened this issue Nov 25, 2018 · 5 comments

Comments

@matchai
Copy link
Owner

matchai commented Nov 25, 2018

Looks like we've got a bit of updating to do for the pyenv section.
This would also be a great opportunity to add testing where we don't have any at the moment. πŸ˜„

🐟 spacefish-bot β€” Pull request copied from: spaceship-prompt/spaceship-prompt#431.

Description

Dropping pyenv section in favor of python section, python section has three display modes.

Variable Value Meaning
SPACESHIP_PYTHON_SHOW always Always display python version information if relevant files exist in directory
SPACESHIP_PYTHON_SHOW true (default) Display python version only inside virtual environment if relevant files exist
SPACESHIP_PYTHON_SHOW false Don't display python version in prompt

Screenshot

python version inside virtualenv

Tasks

  • Update docs
  • Backward compatibility

Related spaceship-prompt/spaceship-prompt#394
Close spaceship-prompt/spaceship-prompt#410

@matchai matchai added Type: Enhancement New feature or request Good First Issue Good for newcomers labels Nov 25, 2018
@spacefish-bot spacefish-bot bot changed the title #431 Dropping pyenv in favor of python section Nov 25, 2018
@salmanulfarzy
Copy link
Contributor

Note it was merged to 4.0 branch and not to master.

@matchai
Copy link
Owner Author

matchai commented Nov 25, 2018

Good call. I'll have this planned for 2.0, which will be parallel to spaceship's 4.0 πŸ‘

@CSergienko
Copy link

Hello! Does this mean that the theme will support other python version managers, like ASDF, virtualenvwrapper, etc, in the near future?

Thank you for the awesome work you've done porting this theme to fish.

@matchai
Copy link
Owner Author

matchai commented Jan 18, 2019

As soon as such features are added to spaceship, we aim to add support for equivalent features in spacefish. πŸ˜„

@CSergienko
Copy link

Fair enough.

@matchai matchai unpinned this issue Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants