Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update french translation #203

Merged
merged 4 commits into from
Dec 24, 2021
Merged

Update french translation #203

merged 4 commits into from
Dec 24, 2021

Conversation

bryanthrmn
Copy link
Contributor

@bryanthrmn bryanthrmn commented Dec 11, 2021 •
edited
Loading

I'm still not done with it, but this is my first version.

adriweb
adriweb requested changes Dec 12, 2021
View reviewed changes
src/strings.asm Outdated Show resolved Hide resolved
src/strings.asm Outdated Show resolved Hide resolved
src/strings.asm Outdated Show resolved Hide resolved
src/strings.asm Outdated Show resolved Hide resolved
src/strings.asm Outdated Show resolved Hide resolved
src/strings.asm Outdated Show resolved Hide resolved
adriweb
adriweb requested changes Dec 12, 2021
View reviewed changes
Copy link
Collaborator

@adriweb adriweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite a few changes to make.

src/strings.asm Outdated Show resolved Hide resolved
@bryanthrmn
Copy link
Contributor Author

Ok, how about the "è" character?

@adriweb
Copy link
Collaborator

adriweb commented Dec 12, 2021

Seems like it would be $8A.

@mateoconlechuga
Copy link
Owner

Any luck on finishing this out?

@bryanthrmn
Copy link
Contributor Author

bryanthrmn commented Dec 24, 2021 via email

@mateoconlechuga
Copy link
Owner

Great thank you! Merry Christmas to you too :)

@mateoconlechuga mateoconlechuga merged commit b4af5c8 into mateoconlechuga:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriweb adriweb adriweb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanthrmn @adriweb @mateoconlechuga