-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the detailsPanel prop while using components overriding breaks the component #282
Comments
I believe this is known. Would you mind trying the latest release? |
Hi, thanks for your reply. I tested with the latest release (3.2.4) and also with 3.1.2 and in both versions the issue appears, only after downgrading to 3.0.17 the issue disappears. |
Interesting. I'll take a look here in a few. If you already know a fix, we would be happy to merge a PR. Thanks again! |
This should be resolved in Thank you! |
#285 please let me know if this is still an issue after upgrading! Thank you. |
Hi, the issue is solved in the new release. Thanks a lot! |
Hi, here is a codesandbox in which the issue can be reproduced: https://codesandbox.io/s/material-table-starter-template-forked-uvmpq?file=/src/index.js.
If you remove the detailsPanel prop (for example for hiding it) while it is open and you are using component overriding for the Row, the MaterialTable breaks and shows the following error:
The issue seems to have first appeared in release 3.1.0; if you change the version in codesandbox to 3.0.17 the component will work correctly.
To reproduce:
Expected behavior
The details panel should disappear without breaking the component.
Desktop:
The text was updated successfully, but these errors were encountered: