Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remove mongogrant dep #984

Open
jmmshn opened this issue Jul 31, 2024 · 2 comments
Open

[Feature Request]: Remove mongogrant dep #984

jmmshn opened this issue Jul 31, 2024 · 2 comments

Comments

@jmmshn
Copy link
Contributor

jmmshn commented Jul 31, 2024

Problem

I think the percentage of people who actually get their credentials from Mongogrant is going to decreasing and most people are just using mongogrant as a shorthand for their credentials (or to anonimize it for demonstration and sharing code)

Proposed Solution

It might make sense to remove the dependency and just move the parsing of the code over to maggma.

Alternatives

save this for a hackathon?? Plan chackathons?

@rkingsbury
Copy link
Collaborator

Hi @jmmshn thanks for the suggestion. Since we've already made mongogrant an optional dependency (see #968 ), I'm not sure I really see the benefit (although I'm not strongly opposed either). You're suggesting to just pull out the relevant bits from mongogrant and insert them into maggma right? Would they live in MongoGrantStore? b/c personally I have us on a path to deprecate MongoGrantStore at some point in the future.

@rkingsbury
Copy link
Collaborator

@jmmshn just resurfacing this question you raised. Any further thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants