Bubble percentage widths up while line breaking in CHTML. #1462
Conversation
| @@ -348,6 +348,7 @@ MathJax.Hub.Register.StartupHook("CommonHTML Jax Ready",function () { | |||
| // | |||
| var node = this.CHTMLnodeElement(); | |||
| line.appendChild(node); | |||
| if (this.CHTML.pwidth && !line.style.width) line.style.width = this.CHTML.pwidth; | |||
There was a problem hiding this comment.
Do you also want to overwrite if line.style.width = 0?
Likewise if pwidth is 0 and width not set?
There was a problem hiding this comment.
pwidth is a percentage width (a string), so always has a percent (and as a string, "0" is not falsey). Similarly, line.style.width will only be set (in this context) if it was set to a percent, and again, styles are always strings (even if set as numbers originally), so even width of 0 will be "0" and not false. In most browsers, 0 is changed to "0px" in any case.
There was a problem hiding this comment.
Ah the pleasure of types...
So I assume none can be the empty string either?
There was a problem hiding this comment.
Yes, when line.style.wodth has not been set, it will be an empty string (not null). That is the case we are testing for, here. Once it is set, it will be non-empty (either a percentage, or something with an explicit em or px measurement).
|
lgtm. |
This fixes the multiple-tagged-equationwith-line-breaks issue that Peter reported in #1441 by making sure the line box gets
width:100%when the line contains an item with 100% width.