Make mhchem have a config parameter to select the new version #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w version (when it is available on the CDN) or the old legacy version.
OK with me but I also don't have strong feelings about it. |
dpvc
changed the title
|
I think this is for @pkra as he is been in the mhchem loop. |
|
Sorry I missed my mention. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make mhchem have a config parameter that can be used to select the new version (when it is available on the CDN) or the old legacy version. The default is the legacy version, so this is an opt-in for the new mhchem, which is what I think we agreed on. The parameter is named
legacy, but I am open to other suggestions.I had to put the old version inside an
if-thenstatement, but I didn't re-indent it, as I didn't want the difference to look extensive than it is. Volker may want me to change that. :-)