Incompatibility with apollo-server ^2.2.0

[jgoux]

Hello,

It seems that there is an incompatibility issue between graphql-middleware and apollo-server@^2.2.0

Here you can find an explanation about what is breaking : apollographql/apollo-server#1935 (comment)

So apparently something in graphql-middleware is turning the introspection query execution (from graphql/execution into a Promise instead of returning an object.

Another related issue : apollographql/apollo-server#1934

In the meantime, the last working version is apollo-server@2.0.5

[nicklaros]

yap, had this issue as well after update my apollo-server dependencies

[abernix]

I'm curious if anyone experiencing this problem (and has a reproduction) would be willing to try modifying graphql-middleware's applicator.ts to have it obey graphql/introspection's isIntrospectionType predicate function prior to applying middleware to it.

Essentially, this incompatibility is occurring because the expectation Apollo Server (now) makes about introspection queries is that they should resolve synchronously (as in, they should not have asynchronous properties or resolvers). This is an expectation seems to be corroborated by graphql itself by logic similar/related to that in graphql/graphql-js#1120.

My claim is that that predicate should be applied prior to wrapping a resolver to maintain the synchronous execution dynamics of introspection queries.

[israelglar]

Hello! @abernix I'm having the same issue but can't figure out what to do to applicator.ts to fix it but I will continue to try
@maticzav since this issue is assigned to you, do have an idea when this will be resolved? Thanks!

[resao]

The same issue is unfortunately present when used with apollo-server-azure-functions. Although in my case I can't find an appropriate version of apollo-server-azure-functions to roll back to :(

[dortamiguel]

I have also this problem whit graphql-shield

[resao]

@ellipticaldoor

There is a temporary (but not very nice) solution which appears to allow "apollo-server-azure-functions": "2.2.6", "graphql-middleware": "^2.0.2" and "graphql-shield": "^4.1.0" work alongside each other.

Following this issue comment apollographql/apollo-server#1935 (comment) I was able to patch the apollo-server-core dependency in my solution and it now works

[dortamiguel]

I think I will wait for a better fix :/

[schickling]

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[dortamiguel]

@schickling Can we reopen this issue? I still get the following error using "graphql-middleware": "^3.0.0" with "apollo-server-express": "2.3.1",

(node:38309) UnhandledPromiseRejectionWarning: Error: The introspection query is resolving asynchronously; execution of an introspection query is not expected to return a `Promise`.

This is how I use it

  const typeDefs = importSchema("./src/schema.graphql");
  const schema = makeExecutableSchema({ typeDefs, resolvers });
  const schemaWithMiddleware = applyMiddleware(schema, permissions);

  const apollo = new ApolloServer({
    schema: schemaWithMiddleware,
    resolvers,
    context: (ctx) => ({ ...ctx, db })
  });

[chanlito]

@ellipticaldoor I'm using graphql-shield v5 seems to be working now.

[kallaspriit]

I can also confirm that with the latest version it works nicely again :)