You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tests for the /hierarchy endpoint are incorrect in that they assume each entry in children_state includes a room_id field. This was removed from MSC2946 at some point, but was never updated in complement.
Synapse no longer depends on this field as of matrix-org/synapse#12991, but still returns it. I assume Dendrite also returns it since those tests are skipped there.
Note that I've attempted to remove this, but it is rather difficult -- the JSONCheckOff filter doesn't seem able to grab the room ID from the parent object and combine it with each state key from children_state.
clokep
changed the title
Incorrectly tests results of MSC2946 /hierarchy response
Incorrectly tests the results of MSC2946 /hierarchy response
Jul 21, 2022
The tests for the
/hierarchy
endpoint are incorrect in that they assume each entry inchildren_state
includes aroom_id
field. This was removed from MSC2946 at some point, but was never updated in complement.Synapse no longer depends on this field as of matrix-org/synapse#12991, but still returns it. I assume Dendrite also returns it since those tests are skipped there.
I believe this would affect:
To test using Synapse I was running the following in my Synapse checkout:
The text was updated successfully, but these errors were encountered: