Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly tests the results of MSC2946 /hierarchy response #416

Closed
clokep opened this issue Jul 21, 2022 · 1 comment · Fixed by #422
Closed

Incorrectly tests the results of MSC2946 /hierarchy response #416

clokep opened this issue Jul 21, 2022 · 1 comment · Fixed by #422

Comments

@clokep
Copy link
Member

clokep commented Jul 21, 2022

The tests for the /hierarchy endpoint are incorrect in that they assume each entry in children_state includes a room_id field. This was removed from MSC2946 at some point, but was never updated in complement.

Synapse no longer depends on this field as of matrix-org/synapse#12991, but still returns it. I assume Dendrite also returns it since those tests are skipped there.

I believe this would affect:

To test using Synapse I was running the following in my Synapse checkout:

$ COMPLEMENT_DIR=~/matrix/complement ./scripts-dev/complement.sh -run "TestClientSpacesSummary|TestClientSpacesSummaryJoinRules|TestFederatedClientSpaces|TestRestrictedRoomsSpacesSummaryLocal|TestRestrictedRoomsSpacesSummaryFederation"
@clokep
Copy link
Member Author

clokep commented Jul 21, 2022

Note that I've attempted to remove this, but it is rather difficult -- the JSONCheckOff filter doesn't seem able to grab the room ID from the parent object and combine it with each state key from children_state.

@clokep clokep changed the title Incorrectly tests results of MSC2946 /hierarchy response Incorrectly tests the results of MSC2946 /hierarchy response Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant