-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec PUT /directory/list (SPEC-102) #417
Comments
It's the -- @richvdh |
we have /directory/list, but that isn't specced. Updating the summary accordingly. -- @richvdh |
Would this mean that this would change the state of the room? If so, why do we need a separate API for this? It's pretty much the same functionality as Also, considering it has a reason, if there's a |
The room directory is intenteded to be an isolated component of the homeserver, such that the "core" homeserver can work without a room directory, and a room directory can live independently of the core homeserver. |
Ah, OK. So when I update a room state with |
Updating |
This endpoint shouldn't exist. @gergelypolonkai appears to be correct. The client's conveys what it wants by submitting the state event to the room's state endpoint. The client's responsibilities end there. If another operation like this takes place it's only conveying redundant information. In this case, the server has to figure out both times if the client is permitted to perform the operation and the client has to handle interaction and errors in both places. What @turt2live is describing is at best an operation the server should be responsible for, and at worst an opaque implementation detail for the client-server/directory-server to work out internally. Furthermore, if directory listing details need to be conveyed, that can be done either in the event's content or with another event type. Either way it means this endpoint shouldn't exist. |
Adds matrix-org#417 Signed-off-by: Travis Ralston <travpc@gmail.com>
fixed by #1141 thanks to @turt2live ! |
PUT /_matrix/client/r0/directory/list/room/<room_id>
is used to manage the visibility of rooms in the room list, but this is undocumented(Imported from https://matrix.org/jira/browse/SPEC-102)
(Reported by @ara4n)
The text was updated successfully, but these errors were encountered: